Skip to content

Update the bundled hiredis code to version 0.11.0. #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update the bundled hiredis code to version 0.11.0. #5

wants to merge 1 commit into from

Conversation

@jparise
Copy link

@jparise jparise commented Oct 5, 2012

This fixes clang 4.1-based builds.

hiredis.c:696:31: error: second argument to 'va_arg' is of incomplete type 'void'
                    va_arg(ap,void);
                    ~~~~~~~~~~^~~~~
/usr/bin/../lib/clang/4.1/include/stdarg.h:35:50: note: expanded from macro 'va_arg'

Alternatively, hiredis could be included as a git submodule (as is done in hiredis-py).

@jparise
Copy link
Author

jparise commented Oct 23, 2012

@antirez, I'm interested in your opinion on the best approach here. Do you prefer the way I upgraded the hiredis library in-line, or should this redis-tools include hiredis as a git submodule?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jparise